Skip to content

test(inbox): wait for the entry reveal before filling the reply in inbox-edit #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Nov 5, 2026
Merged

test(inbox): wait for the entry reveal before filling the reply in inbox-edit #2596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/browser/inbox-edit.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { hoverMessage } from "./message-actions.mjs";
import { test, expect } from "./fixture.mjs";
import { openPage } from "./navigation.mjs";
import { frames } from "./timeline.mjs";

// Browser boundary: Inbox plugin routing and portalled message-menu dismissal
// must focus the same native decorated editor and preserve its reply draft.
Expand Down Expand Up @@ -44,6 +45,13 @@ test("Inbox edits an owned reply in place and restores the reply draft", async (
const own = app.reply(root.id, true);
const row = detail.locator(`[data-message-id="${own.id}"]`);
await expect(row).toBeVisible();
// Opening the conversation reveals its entry reply by focusing that row. In
// WebKit the focus clears the editor selection, so a fill racing the reveal
// types nothing: let the focus and its next-frame acknowledgement land first.
await expect(
detail.locator('[data-message-id][tabindex="-1"]'),
).toBeFocused();
await frames(page);
await reply.fill("Unsent Inbox reply");
const originalNode = await reply.elementHandle();
const edit = async () => {
Expand Down
Loading