[matt2e]

Summary

navigation-groups.spec.mjs "dismissing a failed move restores keyboard focus to its placement or a surviving row" clicked Work's header before the rolled-back row had left Starred. This adds the missing barrier to the journey's failMove helper. The change is test-only: no assertions are loosened, no retries, sleeps or timeouts change, and no product code changes.

Problem

WebKit's navigation-groups.spec.mjs:650 failed once, at await expect(beta).toBeHidden() after the click on Work's summary, on workflow-ui-issues (#2362), a branch that doesn't touch the sidebar.

• run 41946923047: https://github.com/block/buzz-app/actions/runs/41946923047/job/126981730084

In a scan of about 311 failed browser-journey jobs over about 25 hours, this journey failed only this once.

Cause

The trace (artifact browser-journeys-webkit-11) shows the following:

• The 502 lands and the alert appears with the rollback render. The optimistic Starred copy of the row is then an AnimatePresence exit: it stays in the DOM and in layout (inert, aria-hidden, fading), and the row re-enters Work at once.
• The journey's barrier, Work's beta row being visible, passes as soon as that row mounts at about 5% opacity (snapshot opacity 0.046), while the Starred copy is still there.
• The click on Work's summary measured its box with the Starred copy still laid out (y 393–425). Removing the copy moved the header up by a row, to y ≈ 379 in the final screenshot.
• Playwright's hit-target interceptor decides on the first event of a click and doesn't recheck later events. The press landed on the header, and the release landed on the Beta row that slid under it. The browser fired no click on the header, so toggle("group:work", false) never ran.
• The trace is consistent with this. Work's <details> stays open and its content never gets hidden or inert in any snapshot after the click, and the call log shows no retry. The final screenshot has the pointer resting on the Beta row, which shows its hover highlight, and Alpha is still the current channel.

This is the same press-and-release mismatch that #2566 describes for Show more in channel-members-focus. Here the layout shift is an exit animation completing rather than a search result landing.

Fix

After the alert, failMove waits until the sidebar holds exactly one beta row. Only the rolled-back placement in Work remains, so the Starred exit has finished before the journey acts on the layout. The helper runs for both of the journey's failed moves.

Validation

• Adversarial ordering, with requestAnimationFrame held from the 502 until the header press and a 300 ms press-to-release delay on the header click:
  • without the fix: 20/20 failed (10 Chromium, 10 WebKit) with the CI signature. The press landed on the Work summary with two beta rows in the DOM, the release landed on the Beta row, and the click fired on a common ancestor.
  • with the fix: 20/20 passed.
• Whole navigation-groups.spec.mjs, --workers=4 --retries=0 --repeat-each=10: WebKit 100/100 passed (3.8 min) and Chromium 100/100 passed (3.9 min). The machine was heavily loaded (load average about 70), and the WebKit here is Playwright's macOS build, not the Linux build CI uses.
• tsc --noEmit, biome check --error-on-warnings on the changed file and git diff --check are clean. node --test tests/integration/flake-check.test.mjs passes 10/10.

This changes the same file as #2566 (a different journey, so the hunks don't overlap). A green run doesn't prove the flake is gone, because it fired once in about 311 jobs. Hosted CI covers broad validation.

🤖 Generated with Claude Code