Repository navigation
feat(solo): let viewers join read-only spaces #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
65aa01c
da26fac
cb42038
13027b4
2b29082
3525d52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,16 +169,18 @@ export function SoloChatMenuItems({ | |
| {conversionLabel(session, channel.id)} | ||
| </MenuItem> | ||
| )} | ||
| {onLifecycle && !channel.readOnly && !channel.cached && ( | ||
| <ChannelLifecycleMenu | ||
| channelId={channel.id} | ||
| lifecycle={session.channelLifecycle} | ||
| disabled={!!handoff?.lifecycleDialog} | ||
| separator | ||
| noun="chat" | ||
| choose={onLifecycle} | ||
| /> | ||
| )} | ||
| {onLifecycle && | ||
| (!channel.readOnly || channel.viewerRole === "guest") && | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 P3 (optional, UX): Guests see two disabled items next to Leave. Now that joined Guests can open Chat actions, they see "Chat settings" (always disabled for
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Deferring this optional menu cleanup from the copy follow-up. The existing read-only guards keep these actions disabled; hiding the entries would be a separate menu presentation change. Leaving this thread open rather than claiming the cleanup is done. |
||
| !channel.cached && ( | ||
| <ChannelLifecycleMenu | ||
| channelId={channel.id} | ||
| lifecycle={session.channelLifecycle} | ||
| disabled={!!handoff?.lifecycleDialog} | ||
| separator | ||
| noun="chat" | ||
| choose={onLifecycle} | ||
| /> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.