Repository navigation
fix(release): build macOS llama.cpp without OpenSSL - #468
Draft
johnmatthewtennant wants to merge 1 commit into
Draft
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
The v0.6.5 macOS release job failed compiling llama.cpp's vendored cpp-httplib against the runner's Homebrew OpenSSL 4. Goose never uses llama's HTTPS client, so disable OpenSSL discovery for llama.cpp's CMake, as berd-internal already does for internal releases. Co-authored-by: Henry <a0d9f90f86da5f023099d22b8e3599af162d9423a422d8f385a12815de879cf2@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Matthew Tennant <jtennant@block.xyz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.6.5 release run failed in "Build, sign, and stage macOS arm64".
llama-cpp-sys-2compiles llama.cpp's vendored cpp-httplib with HTTPS support whenever CMake finds an OpenSSL. The macOS runner's Homebrew now provides OpenSSL 4, which that httplib doesn't support:This PR sets
CMAKE_DISABLE_FIND_PACKAGE_OpenSSL=TRUEon the macOS release job.llama-cpp-sys-2forwardsCMAKE_*variables to llama.cpp's CMake, and Goose never uses llama's HTTPS client, so llama.cpp builds without OpenSSL no matter which version the runner has.After this merges, dispatch
release.ymlfrommainwithtag: v0.6.5to rebuild the missing macOS payload against the unchanged tag source.Related issue
None found.
Testing
Red/green on an Apple Silicon Mac whose Homebrew default is OpenSSL 4.1.0, building the crate from Goose at the pinned commit
361003ea3:🤖 Generated with Claude Code