Repository navigation
feat(release): state the goose backend in release notes - #458
Merged
Merged
Conversation
Packagers who build Berd against a goose release can't tell from a release whether one will work, since the backend pin is a commit. Add a generated line naming the pinned goose release, or the repository and commit with a note that it is not a goose release. Co-authored-by: Martha <73923046810b68ae182000e74ef7c444383a907df20f81f2ba1008870a6f45a1@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Matthew Tennant <jtennant@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Berd pins its goose backend to a commit in
goose-backend.lock.json, so nothing in a release says whether a tagged goose release can run it. Packagers who ship goose from releases (nixpkgs, in #456) have to test each goose version by hand. When the pin isn't a goose release tag, such as an untagged upstream commit or a fork commit, the release can't run on a goose release, and its notes don't say so.Solution
scripts/generate-release-notes.shappends a generated line before the compare link, read from the lock at the release commit:**goose**: built with goose releasev1.56.0.**goose**: built with aaif-goose/goose commit [361003ea3](…), which is not a goose release.It doesn't claim a minimum compatible goose version, since nothing tests that.
Testing
On Blox, ran the script with a stub
gooseagainst three lock files:Refs #456
🤖 Generated with Claude Code