feat: Adding GNO, USDT, and the respective uniswap v2 pairs, to cover…#6
Open
lgahdl wants to merge 2 commits intoluizhatem/poc-offline-modefrom
Conversation
… all combinations; feat: Creating a new test script that you can pass parameters to define the transaction; refactor: changing from poc-offline-mode to offline-mode; feat: Deterministic deployment addresses;
yvesfracari
approved these changes
Nov 25, 2025
| # Optimizer settings | ||
| solc_version = "0.8.26" | ||
| optimizer = true | ||
| optimizer_runs = 200 |
Author
There was a problem hiding this comment.
More optimizer_runs means that the code will be more gas efficient in the end, I changed just to have a better output in the end, but I didn't verify if there was a big difference from this change tbh
There was a problem hiding this comment.
what is the difference between this file and the playgrond/offline-mode/addresses.json ?
Author
There was a problem hiding this comment.
They are duplicated, will remove one of them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… all combinations;
feat: Creating a new test script that you can pass parameters to define the transaction;
refactor: changing from poc-offline-mode to offline-mode;
feat: Deterministic deployment addresses;
How to test
./playgroundfolderdocker-compose -f docker-compose.offline.yml up -dand wait./test_playground_offline.sh --sellToken GNO --buyToken USDT --sellAmount 10e18 --from 0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d