Conversation
[wip]: still missing the integration with the frontend;
…the order, it's missing the price estimative from the driver;
wip: Clear the mess;
refactor: joining the poc-offline-mode/src with poc-offline-mode/contracts/src
…t to the autogenerated inside the poc-offline-mode folder;
…wap-v2 build output into .gitignore;
…ing the files to configs/offline; fix: fixing the python sign_order.py script;
…, now it will keep it's size after deployment);
… all combinations; feat: Creating a new test script that you can pass parameters to define the transaction; refactor: changing from poc-offline-mode to offline-mode; feat: Deterministic deployment addresses;
feat: configuring docker-compose.offline.yml file to start coingecko mock and add it to the price estimators;
…iswapv2pairs' into luizhatem/cow-542-implement-coingecko-api-mock-for-offline-price-fetching
…ine-price-fetching' into luizhatem/npm-dependencies
…oy-cowhookstrampoline-contract
…ine-price-fetching' into luizhatem/npm-dependencies
…oy-cowhookstrampoline-contract
…nto luizhatem/cow-566-replace-custom-balancessol-with-official-gpv2tradesimulator # Conflicts: # configs/offline/driver.toml # playground/.env.offline # playground/offline-mode/state/anvil-state.json
…oy-cowhookstrampoline-contract # Conflicts: # configs/offline/driver.toml
…nto luizhatem/cow-566-replace-custom-balancessol-with-official-gpv2tradesimulator
…ng unused interfaces; feat: Replacing uniswap built contract by prebuilt bytecodes directly from npm dependency;
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
| - -c | ||
| - | | ||
| if [ -f ./state/anvil-state.json ]; then | ||
| echo "📂 Loading existing blockchain state..." | ||
| anvil --load-state ./state/anvil-state.json --host 0.0.0.0 --port 8545 --chain-id 31337 --block-time 1 --gas-limit 30000000 --code-size-limit 50000 --accounts 10 | ||
| else | ||
| echo "Error: No state file found at /state/anvil-state.json. Please run locally with start-anvil.sh and deploy-all.sh scripts to create the state first." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
question: wouldn't this be better on a script file of its own?
There was a problem hiding this comment.
question: I haven't created docker compose files in a while. Isn't Dockerfile the default path it looks for? Shouldn't it have an extension?
| cargo build --bin orderbook | ||
| target/aarch64-unknown-linux-gnu/debug/orderbook | ||
| env_file: .env.offline | ||
| environment: |
There was a problem hiding this comment.
suggestion: lots of env vars. can't you create an env file and use the env_file attribute, instead of assigning each all of them here?
There was a problem hiding this comment.
question: this is not lowercase. can this become an issue?
There was a problem hiding this comment.
now that I'll take them from environment variable, this will no longer be a problem, but the addresses were being trimmed and lowercased, so this was not a technical issue.
There was a problem hiding this comment.
I'll try to create this structured object from .env.offline, good point
There was a problem hiding this comment.
question: why not import the interface from open zeppelin?
There was a problem hiding this comment.
suggestion: maybe generate each json in a function: that way you don't have so many variables in a single one. you can also read only the needed ones from the env file. as far as ive seen, each one is only used once, so i think that would increase readability.
There was a problem hiding this comment.
question: any way to have each of these steps inside its own file?
feat: Making the test-playground-order.ts work; fix: Coingecko mock now calculates the price using uniswap v2 pairs; chore: removing unused files;
chore: removing unused/duplicated files; feat: using uniswap pairs for coingecko mocked prices;
chore: fixing readme.md;
…et for the coingecko-mock;
fix: Fixing cowshed order tests;
feat: Adding a deployer via docker-compose;
Luizhatem/split deployment
2 participants
Description
Offline mode deployment with test scripts.
Deployment of:
How to test:
Testing an order:
npm run test:order --sellToken USDC --buyToken DAI --sellAmount 100e6 --from 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80Testing cowshed:
npm run test:cowshed