2 qc cleanup of project #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule It does not belong to src directory
2 tasks
There was a problem hiding this comment.
Pull Request Overview
The PR cleans up legacy utilities and solver scripts, standardizes run scripts, and introduces minor style updates in visualization and main entry points.
- Removed outdated modules and submodules (cart2sph, lobpcg_torch, src/Praktyki) and their run scripts
- Added a top‐level
run.shand locked Python to version 3.9.21 - Introduced TODO markers and adjusted string quoting in
visualize.py,main.py, andsrc/util/cub.py
Reviewed Changes
Copilot reviewed 11 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| visualize.py | Added a generic TODO comment for interactive enhancements |
| src/util/cub.py | Changed file-open calls to use double quotes |
| src/util/cart2sph.py | Removed legacy Cartesian-to-spherical converter |
| src/solver/run.sh | Removed outdated solver run script |
| src/solver/lobpcg_torch.py | Removed legacy LOBPCG Torch implementation |
| src/Praktyki | Removed submodule reference |
| run.sh | Added project-level run script |
| main.py | Added TODOs for cleanup and removed old box import |
| .python-version | Specified Python version 3.9.21 |
| .pylintrc | Deleted large deprecated Pylint configuration |
| .gitmodules | Removed submodule definitions |
Comments suppressed due to low confidence (2)
visualize.py:1
- [nitpick] This TODO is quite vague; consider clarifying the intended enhancement or replacing it with a more actionable task or user story.
#TODO it has to be either more interactive or more intelligent than that
src/util/cub.py:19
- [nitpick] The project appears to use single quotes elsewhere; consider aligning open calls to single quotes for consistency with the codebase style.
with open(file_path, "wb") as f:
| #!/usr/bin/env python | ||
| # -*- coding: utf-8 -*- | ||
| #TODO: cleanup of main from boxes, linspaces instead | ||
| #TODO: remove mayavi, use visualize.py instead |
There was a problem hiding this comment.
The TODO indicates removal of Mayavi imports, but the imports remain; please either implement the switch to visualize.py or remove the unused Mayavi references now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.