fix: close the release.yml changelog race - #35
Merged
Merged
Conversation
Same race already fixed in environments/environments-controller: release.yml is triggered asynchronously by the tag push and used to generate CHANGELOG.md and commit it to main itself, after finalize-release.yml had already merged main back into develop -- develop never received that commit. Confirmed happening on the v0.2.4 release: develop needed a manual post-hoc sync. Moved changelog generation into finalize-release.yml, synchronously, right after tagging (so git-cliff picks up the new tag) and before merging back into develop. release.yml no longer touches main -- it just checks out the tip finalize-release.yml already updated and reads the already-current CHANGELOG.md for its --latest release notes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan