release: v0.6.0 - #125
Merged
Merged
release: v0.6.0#125
Conversation
finalize-release.yml merged main back into develop immediately after tagging, racing ahead of code-docs.yml's async push-triggered commit. develop never received that commit, drifting further from main's generated docs on every release cycle -- this time compounded by docs/fix-attached-godoc-comments (#120) also hand-editing the already-drifted docs/code/*.md on develop, which turned silent drift into a real merge conflict that broke v0.5.0's Finalize Release run. Generate and commit docs/code as a step in this job, before merging back into develop, so develop is always caught up regardless of code-docs.yml's own timing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix: regenerate docs synchronously in Finalize Release
Builds out the Domain CR follow-up to Route: internal/domains/domain
was an empty stub, internal/controller/networks/domain.go's Reconciler
was a genuine no-op (fetch, return -- no finalizer, no engine dispatch,
no Runtime field), and internal/cache/domain didn't exist. All three
are now wired the same way Route is: finalizer-gated reconciler,
Engine.Execute dispatch, DomainDomain handling create/update/delete via
DomainService.
Domain's KnativeProvider needs an ACMEConfig (server, account email,
private key secret name) that nothing in this controller previously
supplied -- there was no existing flag or config surface for it. Added
three flags to cmd/main.go and split Domain registration out of
RegisterControllers into its own RegisterDomain(mgr, rt, acmeConfig),
mirroring how RegisterBuild is already split out for its own
dependency (a Shipwright client).
Also fixes a more severe, pre-existing gap this surfaced: neither
Knative (serving.knative.dev, networking.internal.knative.dev) nor
cert-manager.io schemes were ever registered anywhere in this
controller -- Route's own KnativeProvider (DomainMapping) would have
hit "no kind is registered for the type ... in scheme" the first time
it tried to create one, the same class of bug the missing
networksv1alpha1 registration was before it. Added all three to both
RegisterSchemes (production) and testsupport.NewScheme (tests).
Left DomainCache.PublishStatus unwired -- DomainService.Reconcile
doesn't return the values it needs (domainReady, certRef, mappingRef),
and fabricating them would be worse than leaving the gap for whichever
follow-up builds the Route mediator's Domain integration.
Draft: blocked on an environments release containing #316
(DomainService.Teardown) -- go.mod stays pinned at v0.8.0, which
doesn't have it yet. Confirmed the exact failure:
internal/domains/domain/domain.go:165:29: d.domainService.Teardown
undefined (type *application.DomainService has no field or method
Teardown)
everything else in this change compiles and tests cleanly against the
released v0.8.0.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Unblocks DomainService.Teardown, which the Domain domain wiring in this PR depends on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
feat: wire Domain CR through the CQRS engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.6.0
Release branch cut from
develop. Merge fix PRs into this branch before finalizing.Next step: once all fixes are merged, run the Finalize Release workflow.