Repository navigation
ci: run dependency review and workflow lint on pull requests - #127
Merged
Merged
Conversation
Calls release-workflows dev-security.yml (v1.1.0), the security checks policy rule 3 requires on dev. Fixes what zizmor reports: the CLA triggers are marked as reviewed (cla-reusable.yml never checks out pull request code), benchmark checkouts drop persisted credentials, and publish.yml's local workflow calls are marked as reviewed (same-repository calls on stable).
RadixTarget Benchmark Results100000 networks per table, 100000 lookups, median of 5 runs (seed 1337).
Change is in time taken: negative is faster. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #127 +/- ##
===================================
Coverage 100% 100%
===================================
Files 3 3
Lines 605 605
===================================
Hits 605 605 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zizmor dependabot-cooldown (the workflow-lint check on this PR): version updates now wait 7 days after a release is published, so a compromised release has time to be caught and pulled before it is proposed here. Security updates are not delayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dev-security.yml, which calls release-workflowsdev-security.ymlat v1.1.0 (pinned by commit SHA). On every pull request it runs dependency review and the workflow lint (actionlint,zizmor), the security checks publishing policy rule 3 requires ondev. Once this merges, thedevruleset requiresdev-security / dependency-reviewanddev-security / workflow-lint.It also fixes what
zizmorreports in the existing workflows, so the new check starts green:cla.yml: both triggers marked as reviewed.cla-reusable.ymlnever checks out pull request code.publish.yml: the same-repository workflow calls marked as reviewed.benchmark.yml(where present): checkouts no longer persist credentials.dependabot.yml: version updates wait 7 days after a release is published (cooldown), so a compromised release has time to be caught first. Security updates are not delayed.Locally:
actionlint1.7.12 clean,zizmor1.30.1 (the version the check runs) no findings across the repository.