Repository navigation
test_applet_stats depends on live cloudcheck data #191
Description
tests/test_applets/test_applet_stats.py asserts exact cloud_providers counts, and those come from live cloudcheck data. When the data changes, the required test checks fail on dev for every PR.
Current case: cloudcheck 11.1.0 returns ['Amazon', 'Yandex', 'GitHub', 'HPE', 'Microsoft'] for evilcorp.amazonaws.com, so Yandex appeared in the stats. The last passing dev run was 2026-09-29.
Proposed: pin or mock the cloudcheck lookup in the test so the expected providers are fixed by the test, not by the signature data.
Possibly related, in cloudcheck: GitHub, HPE and now Yandex all match any *.amazonaws.com host, although v2fly lists only specific S3 buckets for GitHub (full:github-cloud.s3.amazonaws.com, …) and HPE (full:hpefonts.s3.amazonaws.com). Exact-host entries may be widened to the registrable domain.
Activity
pjhartlieb commentedon Nov 2, 2026
Cause found: a lookup bug in cloudcheck 11.1.0, fixed in 11.2.0 (blacklanternsecurity/cloudcheck@53b1e442, @01b9c7b4). 11.1.0 returns every provider that declares any host under a domain for all hosts in that domain. GitHub, HPE and Yandex each declare one or more
*.s3.amazonaws.combuckets, so every*.amazonaws.comhost matches them; on the test hosts, 11.2.0 returns Amazon only.11.2.0 requires Python 3.11, and bbot-server supports 3.10, so #190 keeps 11.1.0 and updates the expectation. bbot also locks 11.1.0.
pjhartlieb commentedon Nov 2, 2026
The fix lands in bbot 3.1: blacklanternsecurity/bbot#3474 (Python >=3.11, cloudcheck >=11.2.0) and blacklanternsecurity/bbot#3559 reach bbot dev with blacklanternsecurity/bbot#3457. bbot-server stays on 11.1.0, since it gets no further releases before it is archived.