Check minimum CLI version on login#12
Open
daveliu wants to merge 1 commit into
Open
Conversation
daveliu
force-pushed
the
codex/min-cli-version-check
branch
from
July 10, 2026 06:45
c30ad50 to
6b2cc0f
Compare
daveliu
marked this pull request as ready for review
July 10, 2026 06:59
aidewoode
reviewed
Jul 23, 2026
aidewoode
left a comment
aidewoode
left a comment
Member
There was a problem hiding this comment.
I think it also need to add minimum server version on cli to check server version. in the case when user upgraded the cli, but didn't upgrade server, and the server has some breaking api changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
Summary
Check the server
min_cli_versionbefore sending login credentials and show an actionable upgrade error when the installed CLI is too old. The field is optional while older servers are still in use.Requires the companion server change in blackcandy-org/blackcandy#492.
Validation
cargo fmt --checkcargo testcargo clippy -- -D warnings