fix(ui): restore playlist expansion layout - #285
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPlaylist layout calculation now allows expanded playlists to use available body rows. Frame rendering vertically centers collapsed content, with tests covering expanded sizing and centering behavior. ChangesPlaylist layout behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AI_REVIEW_REQUIRED.txt`:
- Line 1: Complete the self-review and delete the AI_REVIEW_REQUIRED.txt marker
file before merging.
In `@ui/model/layout_test.go`:
- Around line 120-135: The test’s expected frame height bypasses the sizing
applied by View(). Update the expected-content setup around renderMainBody and
mainSections to first apply the same ui.FitRect call using m.layout.panelWidth
and m.layout.bodyRows, then build the expected frame through the same pipeline
as View().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ef9558b0-23f8-4d31-85f7-ad7c8708d88e
📒 Files selected for processing (5)
AI_REVIEW_REQUIRED.txtui/model/layout.goui/model/layout_test.goui/model/model.goui/model/view.go
Fixes #283.
Tests:
make checkSummary by CodeRabbit