[PM-41451] Migrate last files off of AssemblyHelpers.GetVersion() - #8137
Draft
justindbaur wants to merge 8 commits into
Draft
[PM-41451] Migrate last files off of AssemblyHelpers.GetVersion()#8137justindbaur wants to merge 8 commits into
AssemblyHelpers.GetVersion()#8137justindbaur wants to merge 8 commits into
Conversation
justindbaur
changed the title
AssemblyHelpers.GetVersion()
justindbaur
changed the title
AssemblyHelpers.GetVersion()AssemblyHelpers.GetVersion()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8137 +/- ##
===========================================
+ Coverage 15.10% 63.04% +47.93%
===========================================
Files 1417 2314 +897
Lines 61422 100480 +39058
Branches 4901 9040 +4139
===========================================
+ Hits 9279 63348 +54069
+ Misses 51978 34946 -17032
- Partials 165 2186 +2021 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-41451
📔 Objective
This was meant to remove AssemblyHelpers out of the remaining unowned files and then delete it but I realized that I missed a cshtml file that is owned by auth. So this is now an auth and unowned files but it repeats the same pattern used in all other PR's.
📸 Screenshots