Skip to content

chore: Add team-ai-sme as Dockerfile co-owner - #240

Merged
SaintPatrck merged 2 commits into
mainfrom
chore/dockerfile-codeowners-ai-sme
Sep 17, 2026
Merged

SaintPatrck merged 2 commits into
mainfrom
chore/dockerfile-codeowners-ai-sme

Conversation

@SaintPatrck

@SaintPatrck SaintPatrck commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

No tracking issue; follow-on to #219, which set @bitwarden/team-ai-sme as this repo's default owner.

📔 Objective

We own this repo but hold no review claim on its **/Dockerfile, so the container image we publish can change without anyone on our team seeing it. Adding us alongside team-appsec and dept-bre leaves both existing gates intact and gives us visibility into the image that ships under our name.

@SaintPatrck
SaintPatrck marked this pull request as ready for review September 16, 2026 19:35
@SaintPatrck
SaintPatrck requested a review from a team as a code owner September 16, 2026 19:35
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.88%. Comparing base (5eea549) to head (c2f6341).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files          15       15           
  Lines        1199     1199           
  Branches      253      253           
=======================================
  Hits          718      718           
  Misses        405      405           
  Partials       76       76           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This is a one-line .github/CODEOWNERS change that reassigns **/Dockerfile from @bitwarden/team-appsec and @bitwarden/dept-bre to the repo's default owner @bitwarden/team-ai-sme. I verified the description's premise: Dockerfile is the only docker-related file that actually exists in the repo, so the remaining .dockerignore, entrypoint.sh, and docker-compose.yml entries match nothing and this is indeed the last real path owned outside the team. No code, workflow, or dependency changes accompany it. The one question below is about team sign-off, not about the change being wrong.

Code Review Details
  • ❓ : Removes team-appsec and dept-bre from the review path for the published container image; CODEOWNERS is self-owned, so those teams are not required to approve their own removal
    • .github/CODEOWNERS:11

Comment thread .github/CODEOWNERS Outdated
@SaintPatrck

Copy link
Copy Markdown
Contributor Author

@withinfocus are you thinking this should be co-owned, or only under @bitwarden/team-ai-sme?

@withinfocus

Copy link
Copy Markdown
Contributor

I think that you should list your team alongside the existing owners for this file, so you can self-manage.

@SaintPatrck SaintPatrck changed the title chore: Set team-ai-sme as Dockerfile CODEOWNER chore: Add team-ai-sme as Dockerfile co-owner Sep 17, 2026
@SaintPatrck
SaintPatrck enabled auto-merge (squash) September 17, 2026 19:43
@SaintPatrck
SaintPatrck merged commit dec884d into main Sep 17, 2026
16 checks passed
@SaintPatrck
SaintPatrck deleted the chore/dockerfile-codeowners-ai-sme branch September 17, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants