Skip to content

Auth/ PM-41503 & PM-41533 - Add openOrgInvite param to SDK registration finish call - #2953

Draft
JaredSnider-Bitwarden wants to merge 1 commit into
mainfrom
auth/pm-41503-and-pm-41533/registration-add-open-org-invite-support
Draft

Auth/ PM-41503 & PM-41533 - Add openOrgInvite param to SDK registration finish call#2953
JaredSnider-Bitwarden wants to merge 1 commit into
mainfrom
auth/pm-41503-and-pm-41533/registration-add-open-org-invite-support

Conversation

@JaredSnider-Bitwarden

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Aug 10, 2026

Copy link
Copy Markdown

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41503
https://bitwarden.atlassian.net/browse/PM-41533

Server PR: bitwarden/server#8159
Server SDK Bindings Update PR: bitwarden/sdk-internal#1372
SDK PR which wires up breaking changes: bitwarden/sdk-internal#1363 (⚠️ unmerged)

📔 Objective

The SDK's UserMasterPasswordRegistrationRequest will gain a new openOrgInvite field (Option<RegistrationFinishOpenOrgInviteData>) to support finishing registration via an open organization invite link once bitwarden/sdk-internal#1363 merges. iOS does not use open-org-invite (that flow is web-only), so this passes nil at the sole call site to satisfy the new required constructor parameter.

📸 Screenshots

n/a

The SDK's `UserMasterPasswordRegistrationRequest` gains a new
`openOrgInvite` field (`Option<RegistrationFinishOpenOrgInviteData>`)
to support finishing registration via an open organization invite
link. iOS does not use open-org-invite (that flow is web-only), so
this passes `nil` at the sole call site to satisfy the new required
constructor parameter.
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Aug 10, 2026
@JaredSnider-Bitwarden JaredSnider-Bitwarden added the ai-review Request a Claude code review label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single openOrgInvite: nil argument to the sole UserMasterPasswordRegistrationRequest construction in CompleteRegistrationProcessor, keeping the call site compatible with the upcoming SDK constructor change. Passing nil is correct for iOS since the open-org-invite registration flow is web-only, and it matches the surrounding pattern where all other invite/token parameters are also nil. A repository-wide search confirms this is the only construction of that type, so no other call sites or fixtures need updating. No security, correctness, or breaking-change concerns were identified.

Code Review Details

No findings.

Merge-order note (not a code finding): the BitwardenSdk package pin in project-common.yml (revision: 3dbc27249f48fcb88c56739ece52e2335701de0b) is unchanged in this PR, and the Test check is currently failing. This is consistent with the PR description's note that the SDK change (bitwarden/sdk-internal#1363) is still unmerged — this PR presumably needs to land after the SDK pin is bumped so CI can compile the new parameter.

Existing tests in CompleteRegistrationProcessorTests.swift do not assert on the other nil invite/token fields either, so not asserting openOrgInvite is consistent with the established test convention and is not flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant