[PM-40646] Fix watch crash on corrupt encrypted data - #2896
Open
potatosips wants to merge 1 commit into
Open
Conversation
|
Codex Audit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Fixes #2895
📔 Objective
Prevent the Bitwarden Watch app from terminating when locally persisted AES-GCM-encrypted Core Data data is malformed or can no longer be decrypted, for example after corruption or a key mismatch.
CryptoServicenow catches AES-GCM sealing and opening failures, logs them, and returnsnil, allowing the Core Data transformer to treat unavailable data safely.🧪 Validation
git diff --checkCryptoServiceno longer containstry!AES-GCM operations orplainData!unwraps.🔒 Security impact
No confidentiality or integrity bypass was demonstrated; this is an availability and robustness fix.