fix: remove HEUCLID_SOURCES hack + LBlocks BUILD_INTERFACE + macOS pip - #5
Merged
Conversation
added 2 commits
March 16, 2026 22:50
- Heuclid is header-only INTERFACE but has .cpp sources that need compiling; add HEUCLID_SOURCES to AStar library (Orientation2D, HeuclidCoreTool, ConvexPolygon2D, Line2D, HeuclidGeometryTools, HeuclidPolygonTools) - Fix HeuclidCoreTool v2.0 namespace (was class, now namespace) - Fix ParameterBasedStepExpansion empty initializer list - Fix StepConstraintCheck orphaned #endif from matplotlib guards - Add matplotlib guards in test/test.cpp for PlotChecker calls - Guard plotEllipsoidPath() in simple2DBodyPathHolder header - Guard conio.h include in testBlock.cpp (Windows-only) - Make LBlocks include PUBLIC so tests inherit All 4 tests passing: footstep_test, block_test, TestConvexHull2D, TestBeizer
- Remove HEUCLID_SOURCES: Heuclid v2.1 is now a STATIC library, no need to manually compile its .cpp files. Just link heuclid target. - LBlocks include: wrap with $<BUILD_INTERFACE:...> to fix CMake export error - macOS pip: add --break-system-packages for Python 3.12+ compatibility - Heuclid FetchContent: lock to v2.1 tag instead of main
Mr-tooth
added a commit
that referenced
this pull request
Mar 20, 2026
fix: remove HEUCLID_SOURCES hack + LBlocks BUILD_INTERFACE + macOS pip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
1. 移除 HEUCLID_SOURCES hack
2. LBlocks include 路径修复
3. macOS pip 安装修复
4. Heuclid FetchContent 版本锁定
验证结果