Keep quoted portal responses Russian, and finish the English pass - #23
Merged
Conversation
The bilingual pass translated four quoted live-portal responses in CHANGELOG.md into English. They are portal facts, not prose, and the rest of the repository already treats them that way: internal/rest/client.go, batch.go and core.go all carry the Russian text verbatim inside English godoc, as do the v3 fixtures. A translated one costs the reader the thing the quote is for. Somebody who hit the error greps for what their own portal actually returned, and "method `documentation.json` not found" is a string Bitrix24 never sent — so the search comes back empty, and the entry that would have explained the failure is the one place they do not look. It is the reasoning CodeOf already uses for returning an error code as it arrived instead of folding it to a familiar one. Restored, each on a single line so it stays greppable: - "Метод `documentation.json` не найден" (two places) - "Ошибка при валидации объекта запроса" - "Не удается распознать выражение select" .gitattributes was the last file carrying Russian comments and is now English. The comment explains the same breakage its CHANGELOG entry does: without the normalization, a working copy at core.autocrlf=true gets CRLF and `gofmt -l .` — the very check CI runs — complains locally about every file at once. Also "in the order sent" -> "in submission order" for the v3 batch reply, which is the term the ErrV3BatchUnsupported godoc uses for the same fact. Outside *.ru.md, the only Cyrillic left in the repository is these quoted portal responses, the three [Русский] links, and the UTF-8 fixtures in internal/phpq. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bilingual pass translated four quoted live-portal responses in CHANGELOG.md into English. They are portal facts, not prose, and the rest of the repository already treats them that way: internal/rest/client.go, batch.go and core.go all carry the Russian text verbatim inside English godoc, as do the v3 fixtures.
A translated one costs the reader the thing the quote is for. Somebody who hit the error greps for what their own portal actually returned, and "method
documentation.jsonnot found" is a string Bitrix24 never sent — so the search comes back empty, and the entry that would have explained the failure is the one place they do not look. It is the reasoning CodeOf already uses for returning an error code as it arrived instead of folding it to a familiar one.Restored, each on a single line so it stays greppable:
documentation.jsonне найден" (two places).gitattributes was the last file carrying Russian comments and is now English. The comment explains the same breakage its CHANGELOG entry does: without the normalization, a working copy at core.autocrlf=true gets CRLF and
gofmt -l .— the very check CI runs — complains locally about every file at once.Also "in the order sent" -> "in submission order" for the v3 batch reply, which is the term the ErrV3BatchUnsupported godoc uses for the same fact.
Outside *.ru.md, the only Cyrillic left in the repository is these quoted portal responses, the three [Русский] links, and the UTF-8 fixtures in internal/phpq.
What and why
Checks
go build ./...go vet ./...gofmt -l .— the output is emptygo test -race ./...Compatibility
Tests