Skip to content

Keep quoted portal responses Russian, and finish the English pass - #23

Merged
ExaltedTrou6 merged 1 commit into
mainfrom
claude/goofy-mccarthy-e416a0
Aug 7, 2026
Merged

Keep quoted portal responses Russian, and finish the English pass#23
ExaltedTrou6 merged 1 commit into
mainfrom
claude/goofy-mccarthy-e416a0

Conversation

@ExaltedTrou6

Copy link
Copy Markdown
Contributor

The bilingual pass translated four quoted live-portal responses in CHANGELOG.md into English. They are portal facts, not prose, and the rest of the repository already treats them that way: internal/rest/client.go, batch.go and core.go all carry the Russian text verbatim inside English godoc, as do the v3 fixtures.

A translated one costs the reader the thing the quote is for. Somebody who hit the error greps for what their own portal actually returned, and "method documentation.json not found" is a string Bitrix24 never sent — so the search comes back empty, and the entry that would have explained the failure is the one place they do not look. It is the reasoning CodeOf already uses for returning an error code as it arrived instead of folding it to a familiar one.

Restored, each on a single line so it stays greppable:

  • "Метод documentation.json не найден" (two places)
  • "Ошибка при валидации объекта запроса"
  • "Не удается распознать выражение select"

.gitattributes was the last file carrying Russian comments and is now English. The comment explains the same breakage its CHANGELOG entry does: without the normalization, a working copy at core.autocrlf=true gets CRLF and gofmt -l . — the very check CI runs — complains locally about every file at once.

Also "in the order sent" -> "in submission order" for the v3 batch reply, which is the term the ErrV3BatchUnsupported godoc uses for the same fact.

Outside *.ru.md, the only Cyrillic left in the repository is these quoted portal responses, the three [Русский] links, and the UTF-8 fixtures in internal/phpq.

What and why

Checks

  • go build ./...
  • go vet ./...
  • gofmt -l . — the output is empty
  • go test -race ./...

Compatibility

  • The change is additive: existing signatures are untouched

Tests

The bilingual pass translated four quoted live-portal responses in CHANGELOG.md
into English. They are portal facts, not prose, and the rest of the repository
already treats them that way: internal/rest/client.go, batch.go and core.go all
carry the Russian text verbatim inside English godoc, as do the v3 fixtures.

A translated one costs the reader the thing the quote is for. Somebody who hit
the error greps for what their own portal actually returned, and "method
`documentation.json` not found" is a string Bitrix24 never sent — so the search
comes back empty, and the entry that would have explained the failure is the one
place they do not look. It is the reasoning CodeOf already uses for returning an
error code as it arrived instead of folding it to a familiar one.

Restored, each on a single line so it stays greppable:

  - "Метод `documentation.json` не найден" (two places)
  - "Ошибка при валидации объекта запроса"
  - "Не удается распознать выражение select"

.gitattributes was the last file carrying Russian comments and is now English.
The comment explains the same breakage its CHANGELOG entry does: without the
normalization, a working copy at core.autocrlf=true gets CRLF and `gofmt -l .` —
the very check CI runs — complains locally about every file at once.

Also "in the order sent" -> "in submission order" for the v3 batch reply, which
is the term the ErrV3BatchUnsupported godoc uses for the same fact.

Outside *.ru.md, the only Cyrillic left in the repository is these quoted portal
responses, the three [Русский] links, and the UTF-8 fixtures in internal/phpq.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ExaltedTrou6
ExaltedTrou6 merged commit f068918 into main Aug 7, 2026
@ExaltedTrou6
ExaltedTrou6 deleted the claude/goofy-mccarthy-e416a0 branch August 7, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant