Fix JS error when computing tab wrapping.#69
Open
bedney wants to merge 3 commits intobitovi:masterfrom
TechnicalPursuit:tab-wrap-fix
Open
Fix JS error when computing tab wrapping.#69bedney wants to merge 3 commits intobitovi:masterfrom TechnicalPursuit:tab-wrap-fix
bedney wants to merge 3 commits intobitovi:masterfrom
TechnicalPursuit:tab-wrap-fix
Conversation
Contributor
|
Awesome! Can you include a test? |
Author
|
So that's fine, but I'm having trouble running the unit tests. I tried 'npm test' and phantomjs was hanging, so I switched testee's target browser to chrome and I noticed that I'm getting errors in the index.html page about not being able to find QUnit resources. Any suggestions? |
Contributor
|
did you run |
Author
|
Ok, got the tests running and updated the forward tabbing test to show wrap behavior. The reverse tabbing test was already showing wraparound... which is interesting since it must've been passing. In any case, feel free to look at this and let me know. This is my first time committing to this codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing tab wrapping behavior, these check expressions will error at the boundary (when i is 0 or is at the last index). This patch checks i at these boundaries before it performs the other check.