Promote develop to main: live socket gate and the block not-found status - #17
Merged
Merged
Conversation
The overlay refuses a websocket upgrade whose Origin is not on its allowlist, and an unset allowlist refuses every origin. A handshake sent without an Origin header is allowed, so every check we had said the live socket worked while every real browser was refused and quietly fell back to polling: pages still updated, and nothing on the server said no. The cutover now sends the header a browser sends and refuses the release if the answer is not 101, naming the setting to fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Core reports an unknown block as "Block not found" rather than as an HTTP status, so the route mapped it to 500 and a hash that is simply not a block became indistinguishable from a server fault. The explorer's own search consults this route for every 64 hex query, so every transaction search reported the whole Bitcoin chain unavailable while Bitcoin was healthy and had answered definitively. The transaction routes beside it already match Core's message this way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Prove the live socket accepts a browser handshake
Answer 404 for a block hash Core does not know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries PR 15 (the cutover now proves the live socket accepts a browser handshake, the check whose absence let the websocket be refused for every real user) and PR 16 (Core's unknown block answers 404 rather than 500, so multichain search stops reporting a healthy Bitcoin as unavailable on every transaction query).
🤖 Generated with Claude Code