Include latest error in AllAttemptsErrored

[nabijaczleweli]

$ git grep AllAttemptsErrored
src/client.rs:                        return Err(Error::AllAttemptsErrored(errors));
src/client.rs:                                        return Err(Error::AllAttemptsErrored(errors));

fixed here

src/raw_client.rs:    Err(Error::AllAttemptsErrored(errors))

already correctly collected

src/types.rs:    AllAttemptsErrored(Vec<Error>),
src/types.rs:            Error::AllAttemptsErrored(errors) => {

consumers

Closes #186

[ValuedMammal]

Concept ACK, however you still have unwrap in your code which isn't great. Maybe it will be better to log the warning first before placing the error into the errors vec.

[nabijaczleweli]

Updated, how's about now?

[ValuedMammal]

In 59c28bd: Include latest error in AllAttemptsErrored

I understand that we can expect errors to be non-empty after pushing an error into it, however this code is dangerous and error prone due to the unchecked container access. The only time e is used outside of the errors vector is to pass a reference to the warn! macro, so it'd arguably be better to log the warning first before moving the value into errors. This is the suggestion I tried to convey in an earlier comment #188 (review).

Please also include a PR description that others can make sense of, and consider using conventional commits. Thanks for your contribution. @nabijaczleweli