Electrum params

[reez]

Description

Adds optional timeout and retry args to ElectrumClient::new, matching electrum-client::ConfigBuilder

Defaults remain unchanged when omitted: timeout = None, and retry keeps upstream’s default.

Notes to the reviewers

Documentation

• bdk_wallet

https://docs.rs/electrum-client/0.24.1/electrum_client/struct.ConfigBuilder.html#method.timeout

https://docs.rs/electrum-client/0.24.1/electrum_client/struct.ConfigBuilder.html#method.retry

• bitcoin
• uniffi
• Other:

Changelog

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing
• I've added exactly one changelog:* label
• I've linked the relevant upstream docs or specs above

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[reez]

@thunderbiscuit would like to slip this into 3.0 release, if possible, heads up

[thunderbiscuit]

ACK 4e7733b.

If you plan on also cherry-picking these commit for a PR on release/3.0, would you mind adding the changelog entry there? Just because on that branch we do have the changelog all prepared and ready.

[thunderbiscuit]

I think we could also sneak in the new Electrum client maybe? Through the update of bdk_electrum to 0.24.0...

[reez]

ACK 4e7733b.

If you plan on also cherry-picking these commit for a PR on release/3.0, would you mind adding the changelog entry there? Just because on that branch we do have the changelog all prepared and ready.

for sure no prob, added #1011 @thunderbiscuit

[reez]

I think we could also sneak in the new Electrum client maybe? Through the update of bdk_electrum to 0.24.0...

yeah I can open up a separate pr testing that out?

[thunderbiscuit]

This is in theory good to merge so feel free to do that if you want, but if you then bump the electrum client you'll have to redo the part of the method that uses timeout, so I suggest you bump the client here first, and use the new timeout() API here.

[reez]

updated bdk_electrum