Skip to content

Check Cargo.lock freshness#1006

Merged
reez merged 2 commits into
bitcoindevkit:masterfrom
reez:check
May 20, 2026
Merged

Check Cargo.lock freshness#1006
reez merged 2 commits into
bitcoindevkit:masterfrom
reez:check

Conversation

@reez
Copy link
Copy Markdown
Collaborator

@reez reez commented May 20, 2026

Description

Adds a locked Cargo check to Rust CI so stale Cargo.lock changes fail clearly.

If the lockfile is out of sync, CI now suggests running cargo check.

Notes to the reviewers

First commit adds cargo check --locked to Rust CI so stale Cargo.lock changes fail.

Second commit wraps the same command in a small shell block so CI can print a clearer hint to refresh the lockfile. (Totally dont have to do it this way so I can remove this commit if we want!)

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez
Copy link
Copy Markdown
Collaborator Author

reez commented May 20, 2026

updated d23b2db to have a better hint @thunderbiscuit

@reez reez requested a review from thunderbiscuit May 20, 2026 15:43
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d23b2db.

@reez reez merged commit d23b2db into bitcoindevkit:master May 20, 2026
4 checks passed
@reez reez deleted the check branch May 20, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants