Check Cargo.lock freshness#1006
Merged
Merged
Conversation
Collaborator
Author
|
updated d23b2db to have a better hint @thunderbiscuit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a locked Cargo check to Rust CI so stale Cargo.lock changes fail clearly.
If the lockfile is out of sync, CI now suggests running
cargo check.Notes to the reviewers
First commit adds
cargo check --lockedto Rust CI so staleCargo.lockchanges fail.Second commit wraps the same command in a small shell block so CI can print a clearer hint to refresh the lockfile. (Totally dont have to do it this way so I can remove this commit if we want!)
Documentation
bdk_walletbitcoinuniffiChangelog
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingchangelog:*labelNew Features:
Bugfixes: