Create submit your business page#4726
Closed
Robertg761 wants to merge 1 commit into
Closed
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submit-businesstemplate for merchants who want free visibilitysubmit-businessURL slugs for all current languages so localized pages do not generate broken linksNotes
I saw #4721 after starting from the issue. This PR is intentionally a fuller implementation: it avoids a hard-coded
/en/submit-businesslink, uses translated strings, adds the business-page link requested in the issue discussion, and uses the current directory/map services already referenced on the Spending Bitcoin page.Testing
ruby -e 'require "yaml"; Dir["_translations/*.yml"].each { |f| YAML.load_file(f) }; puts "yaml ok"'\n-ruby -e 'require "yaml"; missing=[]; Dir["_translations/*.yml"].each do |f| lang=File.basename(f,".yml"); data=YAML.load_file(f).fetch(lang); missing << [lang,"url"] unless data.dig("url","submit-business") == "submit-business"; end; abort(missing.inspect) unless missing.empty?; puts "submit-business route present for #{Dir["_translations/*.yml"].size} languages"'\n-ruby -e 'require "yaml"; en=YAML.load_file("_translations/en.yml")["en"]; %w[title pagetitle summary local-map local-map-text online-search online-search-text business-directory business-directory-text show-bitcoin show-bitcoin-text].each { |k| abort("missing #{k}") unless en["submit-business"][k].is_a?(String) && !en["submit-business"][k].empty? }; puts "submit-business English strings present"'\n-git diff --check\n\nFullbundle install/ Jekyll build could not be run locally because this machine has Ruby 2.6.10 while the Gemfile pins Ruby 2.5.8.\n\nCloses Create custom page for "Submit your business" #1583