Add Keystone 3 Pro to wallet list#4698
Conversation
|
Hi @solariyoung! The Travis CI build failed because the wallet description is too long. The current limit for en.yml is 320 characters. |
|
@devdavidejesus I shortened the wallet description and reran the validation check. Everything looks good now. |
|
@solariyoung Thanks for the submission! My understanding is that the QR code module runs on the main MCU and is not open source. Is that correct? It is required that all MCU firmware be open source for listing. |
|
A few points on the scope of this binary:
Happy to provide further clarification if needed. @crwatkins @devdavidejesus |
|
The requirement for listing is full public source, so I personally won’t be able to perform a further review. Since the Keystone 3 Pro website claims “100% Open Source” I had hoped that criteria could be met. There are some closed source deviations allowed for closed source secure elements that have a defined trust boundary. Code that runs on the MCU in the same address space does not have such a trust boundary. Everyone is always welcome to propose changes to the listing criteria in the form of PRs, but be aware in the past the community has been fairly adamant about the public source requirements. |
This PR adds Keystone 3 Pro to the wallet list.
Hardware features: open source firmware, air-gapped signing via QR codes, and a touchscreen interface.
The BTC-only firmware is intended for minimized-trust Bitcoin workflows. Supports PSBT-based transaction workflows and can be used with compatible Bitcoin wallets such as Sparrow Wallet
Independent security audit reports are publicly available from SlowMist and KeyLabs:
WalletScrutiny: