Remove opt-in RBF#936
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
polespinasa
force-pushed
the
2026-05-05-remove-optinRBF
branch
from
db677ef to
d10a3e6
Compare
Remove the option to signal or not signal for BIP 125 (Opt-in Full Replace-By-Fee). By removing the option in the GUI it will fallback to the wallet configuration which by default is true unless the user changed it using CLI.
polespinasa
force-pushed
the
2026-05-05-remove-optinRBF
branch
from
d10a3e6 to
90eda67
Compare
|
Failing test seems unrelated |
| // append RBF message | ||
| question_string.append("<span style='font-size:10pt; font-weight:normal;'>"); | ||
| question_string.append(tr("You can increase the fee later.")); |
There was a problem hiding this comment.
What if Bitcoin Core is run with -walletrbf=0?
There was a problem hiding this comment.
Have to test to ensure there's no random check that blocks the transaction from being broadcasted but it is redundant.
Anyway there is work ongoing towards deprecating and removing it.
bitcoin/bitcoin#34917
Edit: Just checked and it doesn't matter, the wallet still broadcast it, we are not enforcing RBF even if -walletrbf=0. The only difference is the sequence number value, but has no effect.
Not at all. If this gets merged I can open a follow-up PR to change that line, maybe can just ask to get it modified here bitcoin/bitcoin#34917. |
4 participants
With the whole network mostly running with Full Replace By Fee, it does not make sense to let the user signal or not to signal for RBF on their transactions.
With this PR the transactions created using the GUI will fallback to the wallet configuration in order to signal or not to signal BIP 125. (True by default).