Skip to content

qml: Validate wallet name during wallet creation#686

Open
pseudoramdom wants to merge 2 commits into
bitcoin-core:qt6from
pseudoramdom:duplicate-wallet-name
Open

qml: Validate wallet name during wallet creation#686
pseudoramdom wants to merge 2 commits into
bitcoin-core:qt6from
pseudoramdom:duplicate-wallet-name

Conversation

@pseudoramdom
Copy link
Copy Markdown
Contributor

@pseudoramdom pseudoramdom commented May 6, 2026

Fixes #571

When creating a wallet, the name is checked for

  • invalid/empty names
  • discovered wallet names in wallet dir
  • existing loaded wallets

The same checks are performed for external-signer wallets.

Review notes

This PR is stacked on top of #547. Now rebased on top of qt6

Screenshots

Screenshot 2026-05-06 at 8 50 36 AM

@pseudoramdom
Copy link
Copy Markdown
Contributor Author

I could've written unit test, but the scaffolding for test_walletcontroller is all in #551 already.
Felt it's easier to add later rather than picking that commit and dropping it later when #551 is merged. Thoughts @johnny9 ?

@johnny9
Copy link
Copy Markdown
Collaborator

johnny9 commented May 6, 2026

I could've written unit test, but the scaffolding for test_walletcontroller is all in #551 already.
Felt it's easier to add later rather than picking that commit and dropping it later when #551 is merged. Thoughts @johnny9 ?

I'm fine with that.

@pseudoramdom pseudoramdom force-pushed the duplicate-wallet-name branch from eb2ddbe to 558cf9c Compare May 10, 2026 19:50
@pseudoramdom
Copy link
Copy Markdown
Contributor Author

558cf9c
Rebased on top of qt6 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create wallet: validate wallet name availability before continuing

2 participants