qml: Hide wallet change outputs in activity list#556
Open
pseudoramdom wants to merge 1 commit into
Open
Conversation
johnny9
approved these changes
Apr 30, 2026
Member
|
Please rebase. |
pseudoramdom
force-pushed
the
fix-output-change
branch
from
09e002f to
eba0fea
Compare
Contributor
Author
|
Rebased to eba0fea |
pseudoramdom
force-pushed
the
fix-output-change
branch
from
eba0fea to
574044f
Compare
johnny9
approved these changes
May 8, 2026
This fixes the wallet activity list showing change outputs as separate outgoing & incoming transactions for normal sends. Tests added: - Verifies sender change outputs are hidden. - Verifies incoming payments to change addresses are still shown.
pseudoramdom
force-pushed
the
fix-output-change
branch
from
574044f to
abba7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the wallet activity list would show change outputs as separate outgoing & incoming transactions for normal sends.
Tests added:
Fixes #555
Note - I used an LLM agent to generate the unit tests. Looked fine to me at first glance.