Add wallet migration flow#539
Open
johnny9 wants to merge 5 commits into
Open
Conversation
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
688fbdf to
d35d395
Compare
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
50d8c8c to
f0fe7f7
Compare
Collaborator
Author
|
Related to #517 |
johnny9
added a commit
to johnny9/BitcoinCoreAppDevelopment
that referenced
this pull request
Apr 27, 2026
# Conflicts: # .github/workflows/gui-functional-tests.yml
MarnixCroes
reviewed
May 6, 2026
Contributor
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
Maybe you're aware, but I don't see it mentioned, there should be a way to enter a passphrase if needed.
| enabled: !root.updatingPhase | ||
| text: { | ||
| if (root.successPhase) { | ||
| return qsTr("Next") |
Contributor
There was a problem hiding this comment.
Suggested change
| return qsTr("Next") | |
| return qsTr("Done") |
makes more sense
| root.back() | ||
| } | ||
| } | ||
| rightItem: NavButton { |
Contributor
There was a problem hiding this comment.
Having both cancel and back is unnecesary
| Layout.rightMargin: 20 | ||
| header: { | ||
| if (root.successPhase) { | ||
| return qsTr("Update completed") |
Contributor
There was a problem hiding this comment.
nit, maybe Wallet successfully migrated is better?
Collaborator
Author
548 adds the password dialog. So I guess depending on which gets merged first I'll add the dialog for migration instead of a blank password. |
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
f0fe7f7 to
c79f2d9
Compare
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
96b06c3 to
1a86cdf
Compare
Collaborator
Author
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
1a86cdf to
3ecc865
Compare
Collaborator
Author
|
another trivial rebase |
johnny9
force-pushed
the
pr/feature-parity-13-migration-flow
branch
from
3ecc865 to
5055da4
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517