coldcard: bump firmware, add edge, display taproot address, restore test_signtx (ex. multisig) - #849
Open
Sjors wants to merge 12 commits into
Open
coldcard: bump firmware, add edge, display taproot address, restore test_signtx (ex. multisig)#849Sjors wants to merge 12 commits into
Sjors wants to merge 12 commits into
Conversation
Restrict the Coldcard transaction cases to singlesig inputs, which do not require multisig wallets to be preloaded in the simulator.
Drop note to keep COLDCARD_VERSION in sync, because the install action consumes the simulator artifact built by setup_environment.sh.
Initialize only the firmware submodules needed by simulator setup instead of recursively fetching unrelated embedded dependencies. Build against the system libffi rather than MicroPython's bundled copy, which current Autoconf rejects. Apply the multisig fixture with git apply rather than git am, so updating the firmware checkout does not require resetting a fixed number of commits.
Extract the Coldcard firmware setup into a helper for reuse by other firmware variants. Review hint: git show --color-moved=dimmed-zebra \ --color-moved-ws=allow-indentation-change
Add an Edge target to simulator setup and include its output in the Coldcard simulator build matrix. Reuse Edge's valid multisig policy under the HWI fixture name. Co-authored-by: scgbckbone <scgbckbone@proton.me>
Expose the Edge simulator through the device test runner and account for its unsupported multisig display behavior. Co-authored-by: scgbckbone <scgbckbone@proton.me>
This was referenced Aug 18, 2026
Keep the existing test modes while allowing callers to select Python versions.
Install the cached Edge simulator in GitHub Actions and run all source and distribution test modes on Python 3.14. Co-authored-by: scgbckbone <scgbckbone@proton.me>
Co-authored-by: scgbckbone <scgbckbone@proton.me>
Member
Author
|
Looks like Azure is on strike, with Jade and ColdCard simulator build jobs being stuck. |
Draft
Member
Author
|
Added e1442a0 to stop needlessly downgrading to PSBT v0. |
Update checkout and artifact actions to their latest major versions. This avoids the Node.js 20 fallback warning on current runners.
Member
Author
|
The edge builder job consistently gets stuck during apt update. The other builders sometimes do. It's probably an infrastructure issue, but I added a commit to set max retries and timeouts to apt update and install. That way fail early instead idling until the runner times out hours later. I also bumped the actions versions. That avoids some existing warnings about old nodejs, but I would not expect it to fix anything. |
GitHub-hosted runners can hang while accessing the prioritized Azure Ubuntu mirror. Retry transient failures, bound connections to 30 seconds, and bound the full update and install commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Edge firmware supports displaying taproot single sig addresses, and more importantly MuSig2.
Rather than blowing up the CI matrix, this PR only adds it for Python 3.14. It can be easily be dropped again if all Edge features we care about land in their regular firmware.
The first commit re-enables
test_signtx, which was already possible. It achieves this by dropping multisig for ColdCard in that these. This can be re-introduced by #792.The multisig patch is adjusted or Edge. Alternatively after #847 it could be dropped entirely. It builds, but CI won't cover it until #792. I did test it locally.
COLDCARDedge taproot #725