Bump dependencies and modernize pyproject.toml - #843
Merged
Conversation
achow101
force-pushed
the
2026-08-bump-deps
branch
3 times, most recently
from
August 5, 2026 06:02
48095b1 to
0a274a0
Compare
achow101
marked this pull request as ready for review
August 5, 2026 06:06
achow101
force-pushed
the
2026-08-bump-deps
branch
from
August 5, 2026 17:18
0a274a0 to
7f51463
Compare
Caret and tilde are poetry specific specifiers, use inequality which is python standard.
setup.py was automatically generated. As our minimum python ships a pip that fully supports pyproject.toml for specifying the project config, there's no need to keep setup.py.
achow101
force-pushed
the
2026-08-bump-deps
branch
3 times, most recently
from
August 5, 2026 21:45
f4c6700 to
c244fca
Compare
Member
My LLM thinks that installing |
achow101
force-pushed
the
2026-08-bump-deps
branch
from
August 10, 2026 22:42
c244fca to
cc7333f
Compare
Member
|
Ok, that worked for 3.13, but not for 3.14.
Bumping jsonschema 4.18 will make that go away, but Speculos v0.26.10 pins it at <4.18. cc @bigspider The following works: diff --git a/.github/actions/install-sim/action.yml b/.github/actions/install-sim/action.yml
index f6630e6..4df5537 100644
--- a/.github/actions/install-sim/action.yml
+++ b/.github/actions/install-sim/action.yml
@@ -59,10 +59,14 @@ runs:
apt-get update
apt-get install -y libusb-1.0-0 qemu-user-static gcc-arm-linux-gnueabihf libsdl2-image-dev libvncserver-dev
tar -xvf speculos.tar.gz
poetry run pip install -e test/work/speculos
pip install -e test/work/speculos
+ if [[ "$(python --version)" == Python\ 3.14.* ]]; then
+ poetry run pip install --upgrade jsonschema==4.18.0
+ pip install --upgrade jsonschema==4.18.0
+ fi
- if: startsWith(inputs.device, 'ledger')
uses: actions/download-artifact@v4
with:
name: ${{ inputs.device == 'ledger-legacy' && 'ledger_app_legacy' || 'ledger_app' }} |
Member
|
Well that was quick. |
achow101
force-pushed
the
2026-08-bump-deps
branch
from
August 11, 2026 18:09
a8c1663 to
674af36
Compare
achow101
force-pushed
the
2026-08-bump-deps
branch
from
August 11, 2026 19:48
674af36 to
d26304f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
All other dependencies should have the same minimum and maximums.
typing-extensions is dropped as we aren't using it anymore.
Ran
poetry updateto update all locked dependencies to latest version.The pyproject.toml file is also modernized to follow PEP 517. Additionally, given that PEP 517 is in use in our minimum python version, we can safely drop the setup.py.
Depends on #819 for the python bump.