Repository navigation
fix(ci): build the sdist before the manylinux wheel - #426
Merged
Merged
Conversation
Reorder the release workflow so the sdist step runs before the wheel build. On runners where the manylinux container leaves dist/ root-owned and the runner cannot chown it back (seen on Blacksmith in libitofin v0.49.0, fixed there in #1397), the host-side maturin sdist fails with Permission denied. Building the sdist first creates dist/ as the runner user, and the container can still write the wheel into it afterward. This is preventive here since ubuntu-latest still chowns successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder the release workflow so the sdist step runs before the wheel
build. On runners where the manylinux container leaves dist/ root-owned
and the runner cannot chown it back (seen on Blacksmith in libitofin
v0.49.0, fixed there in #1397), the host-side maturin sdist fails with
Permission denied.
Building the sdist first creates dist/ as the runner user, and the
container can still write the wheel into it afterward. This is
preventive here since ubuntu-latest still chowns successfully.