✨ add hound lamp freeze functionality #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
reviewed
Dec 25, 2019
|
|
||
| public class LevelStageBootstrap implements LevelBootstrap { | ||
|
|
||
| CircuitModelMap circuitModelMap; |
bitbrain
reviewed
Dec 25, 2019
|
|
||
| // TODO: inject a lookup map to find circuit by game object | ||
| // TODO: introduce object to model stereotype Map<GameObject, Model> which can be added to the context | ||
| // Map<Model.class,Map<GameObject, Model>> |
Owner
There was a problem hiding this comment.
very interesting idea. We might wanna add this to braingdx if it fulfills these criterias:
- it saves a lot of time when creating new games
- it does not introduce strange coupling at scale (checkout https://github.com/bitbrain/galacticum as a reference, this is a project of mine where I attempted to create an infinite 2D space game but it failed due to coupling issues. I want to avoid them in braingdx)
Let's see some code in action and see if it's useful!
bitbrain
reviewed
Dec 25, 2019
| if(circuit.getState() == Circuit.State.ON){ | ||
| double xSep = hound.getLeft() - object.getLeft(); | ||
| double ySep = hound.getTop() - object.getTop(); | ||
| double rSep = Math.pow(Math.pow(xSep, 2) + Math.pow(ySep, 2), 0.5); |
Owner
There was a problem hiding this comment.
you actually don't need that. Checkout the RayHandler class available through the LightingManager. I'd prefer this since we then can use different types of lights (like cone light for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs tidying