Repository navigation
feat: support symfony 8, scheb 2fa 8 and sylius 2.3 - #18
Open
jeromeengeln wants to merge 2 commits into
Open
jeromeengeln wants to merge 2 commits into
jeromeengeln wants to merge 2 commits into
Conversation
- widen composer constraints (php ^8.3, scheb/2fa ^7.13 || ^8.0, endroid/qr-code-bundle ^6 || ^7) - load services from yaml instead of xml (XmlFileLoader removed in symfony 8) - add native return types required by symfony 8 - remove unused behat/mink dev dependencies incompatible with symfony 8 - add .license-checker.yml for license-checker 3.x - extend CI matrix to php 8.3/8.4 and symfony 7.4/8.0 - update README, CHANGELOG and UPGRADE Signed-off-by: Jérôme Engeln <jerome.engeln@adeliom.com>
crydotsnake
suggested changes
Oct 10, 2026
Signed-off-by: Jérôme Engeln <jerome.engeln@adeliom.com>
crydotsnake
approved these changes
Oct 17, 2026
crydotsnake
left a comment
Member
There was a problem hiding this comment.
I tested the 2auth admin/shop flow locally in the test application. Everything was working fine for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
What
Makes the plugin installable and tested on Sylius 2.3 / Symfony 8 / scheb/2fa-bundle 8, while keeping Symfony 7.4 and Scheb 7 working.
Changes
^8.3.scheb/2fa-bundle,scheb/2fa-emailandscheb/2fa-google-authenticatorare now^7.13 || ^8.0. Composer refuses a mix of Scheb majors.endroid/qr-code-bundleis now^6.0 || ^7.0.extra.symfony.requireis now^7.4 || ^8.0.sylius/test-applicationis now^2.3.0@alpha.symfony/*dev packages are widened to^7.4 || ^8.0.config/services*.xmlare converted to YAML andYamlFileLoaderis used in the extension, becauseXmlFileLoaderwas removed in Symfony 8. I compared the resultingcontainer definitions before and after, and they are identical.
getSubscribedEvents(): arrayandVerificationCodeType::buildForm(): void, which are mandatory in Symfony 8.features/is empty andCI doesn't run Behat.
behat.yml.distis left untouched.CI doesn't run Behat.
behat.yml.distis left untouched.madewithlove/license-checkeris now^2.1 || ^3.0, with a new.license-checker.ymlfor 3.x. The.allowed-licensesfile stays for 2.x.fail-fast: false.0.3.0CHANGELOG entry and UPGRADE notes.Breaking / upgrade notes
0to-100. Check custom authenticators on theadmin/shopfirewalls. This is noted inUPGRADE.md.Testing
Run locally on PHP 8.4.1 (
check-license,cs-check,cs-twig,analyzeandtest, with the 56 existing tests):Not verified locally
scheb_two_factor.authentication.attemptevent used by the plugin stillexist. I'd appreciate a manual check of the admin/shop 2FA login flow (the
-100priority).