Repository navigation
[XML2PHP] convert service definition configurations from xml to php - #11
Closed
crydotsnake wants to merge 1 commit into
Closed
crydotsnake wants to merge 1 commit into
crydotsnake wants to merge 1 commit into
Conversation
Member
Author
|
FYI @shochdoerfer |
Member
Author
|
I think it would be a good idea to merge this PR last. Due to #10, there will be merge conflicts because I’ve updated the service xml configuration. |
Member
Author
|
I will open a new PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the
XmlFileLoaderis marked as deprecated in Symfony 7.4 and will be removed in Symfony 8, this PR ensures that the service’s definition files are converted from XML to PHP in preparation for Symfony 8 support.See also: Sylius/Sylius#18760