Keep api compatibility#54
Draft
HenrikJannsen wants to merge 6 commits into
Draft
Conversation
The reason is BouncyCastle 1.64 removed point compression tracking. (cherry picked from commit 164fa9c)
(cherry picked from commit aff7435)
(cherry picked from commit d43ee52)
Restored deprecated ECKey.compressPoint(ECPoint) and ECKey.decompressPoint(ECPoint) in ECKey.java. Restored deprecated ECKey.fromPublicOnly(ECPoint) in ECKey.java, defaulting to compressed encoding and documenting the explicit boolean overload. Added focused compatibility tests in ECKeyTest.java. Verified against /Users/dev/IdeaProjects/bisq: Bisq has several ECKey.fromPublicOnly(...) call sites, but they are byte[] usages, not the removed ECPoint overload. I found no direct Bisq usages of compressPoint, decompressPoint, or fromPublicOnly(ECPoint). So this change is not really required.
HenrikJannsen
force-pushed
the
Keep-API-compatibility
branch
from
c79fe91 to
b0230bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #51
This is optional as Bisq does not use those APIs