[ENH] Use API to make row selection in disjunction mode. - #7325
Open
krystofair wants to merge 1 commit into
Open
krystofair wants to merge 1 commit into
krystofair wants to merge 1 commit into
Conversation
This API was already there, but not used. Add setting for it in widget and attach to callback `conditions_changed`. Set it as True by default as it was on the beginnig.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7325 +/- ##
==========================================
+ Coverage 88.97% 88.99% +0.01%
==========================================
Files 337 337
Lines 74591 74593 +2
==========================================
+ Hits 66368 66382 +14
+ Misses 8223 8211 -12 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API was already there, but not used. Add setting for it in widget and attach to callback
conditions_changed. Set it as True by default as it was on the beginnig.Description of changes
Add new setting with
Trueas default.Add checkbox for this new setting.
Use parameter
conjunctionofValueswhen make filters.It seems to work as I expected: "Single instance has at least one condition satisfied."
Is there better place for checkbox? I think if the next option will be introduced it can change then.
There is
negateoption too, but please, one step at a time. :)Includes