Ingest: catch exceptions in --dev#236
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the ingest --dev workflow by (1) preventing unexpected exceptions during ingestion updates from crashing the process and (2) ensuring the background Next.js server is terminated when the ingest process terminates unexpectedly.
Changes:
- Add a try/catch around
updatePaths()insideupdateDb()to prevent unhandled exceptions from bubbling out. - In
scripts/ingest.ts, run Next.js in a detached process and add process-level handlers (uncaughtException,unhandledRejection, signals) to terminate the Next.js process tree. - Add the
tree-killdependency (and lockfile entry) for process-tree termination.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ingest/index.ts |
Wraps updatePaths() in try/catch to prevent uncaught exceptions from escaping update runs. |
scripts/ingest.ts |
Adds dev-mode shutdown handlers and uses tree-kill to terminate the spawned Next.js process tree. |
package.json |
Adds tree-kill dependency. |
yarn.lock |
Lockfile update for tree-kill. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f17a751 to
ff50055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases that I cannot replicate,
ingest --devwould get an uncaught exception and kill the app without killing the background server process.This PR