Conversation
…ents file Resolves bio-learn#200. Models like HurdleInflammAge expose their required sites through methylation_sites() but have no model_file entry. The doc generator showed N/A for these models because it only read static definition dicts, not instantiated objects. Update get_model_cpg_sites() in doc/generate.py to try instantiating the model and calling methylation_sites() when model_file is absent, falling back to N/A with the exception message only if instantiation fails.
Member
|
Thanks Stalin, will take a look and see if this gets the fix in. Appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #200 — models like
HurdleInflammAgeshowedN/Ain docs because the generator only read static definition dicts.Fix in
doc/generate.py: Try instantiating the model and callingmethylation_sites()whenmodel_fileis absent.Test plan
python doc/generate.py—HurdleInflammAgerow shows a site count instead of N/A