Skip to content

fix(web): retain same-home service pickers with a different primary - #2

Merged
binjamshid merged 1 commit into
binjamshid:fix/open-in-same-home-servicefrom
jdd-canada:fix/31358-secondary-home-picker
Nov 8, 2026
Merged

binjamshid merged 1 commit into
binjamshid:fix/open-in-same-home-servicefrom
jdd-canada:fix/31358-secondary-home-picker

Conversation

@jdd-canada

Copy link
Copy Markdown

A same-home bearer service loses its workspace and file-preview editor controls when a different environment is primary, such as a Windows service alongside a WSL primary. This addresses the remaining finding on pingdotgg#31358 (review) and targets that PR's existing author branch.

Carry verified matching-home bearer provenance with the resolved open route and let both picker callers use it. Preserve visibility for the primary and no-primary cases, the existing hidden unrelated local secondary, and SSH/remote routing and permission checks. Include provenance in resolution equality so controls update even when the route stays local-exec.

Verification:

  • vp run check:changed origin/pr-31358 --concurrency 2 passes format, lint, both knip checks, typecheck, 107 tests across nine files, and four React Compiler checks.
  • The ChatView and file-preview browser regressions both fail with the parent visibility rule and pass with this correction. ChatView checks the workspace control and shortcut target; preview clicks the editor action and verifies the selected file and destination environment.
  • The real resolution atom is exercised through its React hook: missing home identity on a desktop-managed secondary, matching-home recovery while the mode stays local, then an SSH target that must lose the same-home flag. Existing resolver coverage retains mismatched-home and SSH-route precedence checks.

These captures use Linux Chromium with the repository's deterministic server fixture and injected different-primary/matching-home metadata. They reproduce the environment arrangement without claiming a native Windows/WSL run. The workspace fixture has no installed editors, so its restored control is disabled; the preview fixture supplies VS Code and verifies the editor command. No real agent turn or live workstation state is used.

Workspace before Workspace after
Different-primary same-home service missing its workspace editor control Same service retaining its workspace editor control
File preview before File preview after
Different-primary service preview missing its editor button Same service preview retaining its VS Code button

Implementation: GPT-6.1 Sol in T3 Code through the Codex harness.

Carry matching-home bearer provenance alongside remote-open resolution. Keep workspace and file-preview editor controls visible for that service when another environment is primary, while preserving unrelated secondary behavior.

Verification: check:changed origin/pr-31358 passed, including 107 tests and four React Compiler checks. Both browser regressions fail with the parent visibility rule and pass with the correction.
@binjamshid
binjamshid merged commit 828d70c into binjamshid:fix/open-in-same-home-service Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants