Glad support and a few other things#105
Open
m00se-3 wants to merge 17 commits intobillyquith:gworkfrom
Open
Conversation
m00se-3
commented
Oct 19, 2023
|
|
||
| // Create our unittest control (which is a Window with controls in it) | ||
| auto unit = new TestFrame(canvas); | ||
| auto unit = new Gwk::Test::TestFrame(canvas); |
Author
There was a problem hiding this comment.
This might have been my compiler settings causing this, but my compiler didn't like the namespaces not being there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes were made to integrate GWork with a side project of mine, hopefully that explains some of the seemingly random changes.
In addition to the code reviews, feel free to provide feedback on the pull request overall. This is my first attempt at contributing to open source, so any advice is welcome.