Conversation
The old implementation sliced by byte index (&s[..max]), which cut inside multibyte UTF-8 characters like 性 (bytes 38..41) and panicked at runtime. Use unicode-width to compute display width per character and break on char boundaries instead. - Add unicode-width 0.2 dependency - Rewrite truncate() with char_indices() + UnicodeWidthChar - Use UnicodeWidthStr for width calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TUI panics when encountering filenames with multibyte Unicode characters (e.g. Chinese).
Repro: run
disky tuion a directory containing paths like【不忘初心】Windows10…iso— it hits:Root cause:
truncate() &s[..max]slices by byte index, which cuts inside 3-byte UTF-8 sequences.Fix
unicode-width = "0.2"dependencytruncate()usingchar_indices()+UnicodeWidthCharto respect char boundaries and CJK display width (2 cols)All 91 tests pass.