Repository navigation
BUG: make conditional delta function available for condition - #1155
Open
ColmTalbot wants to merge 1 commit into
Open
ColmTalbot wants to merge 1 commit into
ColmTalbot wants to merge 1 commit into
Conversation
mj-will
approved these changes
Oct 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2026
Currently, we can't sample using a prior like the one below. There's always a way around this, but it feels more natural to not have to. As a concrete example I'm working with $p(\chi_{\rm eff} | q)$, $p(\chi_2 | \chi_{\rm eff}, q)$, $p(\chi_1 | \chi_{\rm eff}, \chi_2, q) = \delta(...)$, $p(\chi_{1, \perp} | \chi_1)$.
To work around it, I would need to add some new conversions.
```python
a = Uniform(0, 1)
b = ConditionalDeltaFunction(... some condition that depends on a...)
c = ConditionalUniform(... some condition that depends on b...)
```
mj-will
force-pushed
the
conditional-delta-function-not-fixed
branch
from
October 20, 2026 07:41
35cb8a2 to
530fa42
Compare
mj-will
enabled auto-merge
October 20, 2026 07:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we can't sample using a prior like the one below. There's always a way around this, but it feels more natural to not have to. As a concrete example I'm working with$p(\chi_{\rm eff} | q)$ , $p(\chi_2 | \chi_{\rm eff}, q)$ , $p(\chi_1 | \chi_{\rm eff}, \chi_2, q) = \delta(...)$ , $p(\chi_{1, \perp} | \chi_1)$ .
To work around it, I would need to add some new conversions.