Pass server interceptor registry to controllers - #237
Open
ydah wants to merge 1 commit into
Open
Conversation
ydah
force-pushed
the
fix/server-interceptor-registry
branch
from
August 9, 2026 23:05
8000284 to
0a1e0ae
Compare
ydah
force-pushed
the
fix/server-interceptor-registry
branch
from
August 9, 2026 23:25
0a1e0ae to
519bb5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Gruf::Serveraccepts a custominterceptor_registry, and its interceptor management methods update that registry. However, bound services were registered with gRPC as classes, whileControllers::Basealways prepared interceptors from the globalGruf.interceptorsregistry.As a result, server-specific interceptors were never executed during request handling.
This passes the server's interceptor registry through bound service instances to
Controllers::Base, while preserving the global registry as a fallback for controllers instantiated directly.How was it tested?