Conversation
ydah
force-pushed
the
fix/output-metadata-timer-yield
branch
from
August 9, 2026 23:04
e140227 to
ecce074
Compare
ydah
force-pushed
the
fix/output-metadata-timer-yield
branch
from
August 9, 2026 23:27
ecce074 to
70efd5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
OutputMetadataTimeris enabled by default, but currently returns early without yielding whenactive_calldoes not supportoutput_metadata.This causes the controller body to be skipped and
nilto be returned for test doubles, custom call paths, or future gRPC changes.This change yields directly and returns the request result when output metadata is unavailable, while preserving the existing timing instrumentation for supported active calls.
How was it tested?
output_metadata