fix(account): TRAC-686 remove duplicate id="default_instrument" on edit payment method page#2661
Conversation
…payment method page
jairo-bc
changed the title
jairo-bc
changed the title
parthshahp
approved these changes
May 21, 2026
bc-yevhenii-buliuk
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The Update Payment Method page (
Account > Payment Methods > Edit) renders two<input type="checkbox">elements that both haveid="default_instrument", producing invalid markup and an accessibility violation.The duplicate input is leftover from the pre-
PAYMENTS-4944template, which usedcustomer.payment_methods.selected_payment_methoddirectly. When that change refactored the form to use{{#with customer.edit_stored_instrument}}and renamed the field tois_default, it left the old<input name="default_instrument">in place.This PR removes the duplicate input so each ID is unique on the page.
Requirements
Tickets / Documentation
Screenshots (if appropriate)