Skip to content

Add desktop back and forward navigation#154

Merged
bholmesdev merged 4 commits into
mainfrom
feature/issue-111-navigation-history
Jul 11, 2026
Merged

Add desktop back and forward navigation#154
bholmesdev merged 4 commits into
mainfrom
feature/issue-111-navigation-history

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Closes #111

Summary

  • Adds an in-memory per-workspace document navigation history for the desktop app.
  • Adds Back/Forward toolbar buttons with CmdOrCtrl+[ / CmdOrCtrl+] shortcut hints and matching keyboard handling.
  • Adds View menu Go Back / Go Forward items with enablement synced from the renderer.
  • Rewrites/prunes history entries during file rename, move, and delete operations.
  • Covers core stack behavior with desktop store/action tests.

Validation

  • pnpm check
  • pnpm --filter @hubble.md/editor build && pnpm --filter @hubble.md/ui build && pnpm --filter @hubble.md/desktop test -- src/store/actions.test.ts
  • pnpm build:desktop
  • Desktop end-to-end verification via .agents/skills/test-desktop-app/SKILL.md
    • Ran HUBBLE_DESKTOP_ENABLE_CDP=1 xvfb-run -a pnpm --dir apps/desktop dev -- --no-sandbox.
    • Drove the real Electron renderer over CDP.
    • Opened project-ideas.mdREADME.md, verified Back/Forward enablement, navigated with Ctrl+[ and Ctrl+], then navigated with the toolbar Back/Forward buttons.
    • Captured a screenshot of the verified flow as a conversation artifact.

Notes

  • The desktop app required xvfb-run and --no-sandbox in this Linux sandbox; the app was stopped afterward and no Electron dev process remained.

Conversation: https://app.warp.dev/conversation/a90cd638-d897-4e0a-8a20-4ade3cf524a8
Run: https://oz.warp.dev/runs/019f4751-49b3-707f-9e17-7f88602923bf

This PR was generated with Oz.

Co-Authored-By: Oz <oz-agent@warp.dev>
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hubble-md-web Ready Ready Preview, Comment Jul 11, 2026 1:20pm

@jambronner

Copy link
Copy Markdown
Contributor

Tested this locally against my linked Markdown workspace. The navigation behavior works well, including Back/Forward through linked notes.

I did find a macOS layout issue when the sidebar is open: the navigation buttons remain close to and occasionally overlaps with the window traffic lights instead of aligning with the right side of the sidebar header.

I believe this is because ToolbarActions reads --sidebar-width, but that custom property is defined on the Sidebar element. Since the Toolbar and Sidebar are siblings in App.tsx, the Toolbar cannot inherit it and falls back to 114px.

A possible fix would be to expose the sidebar width on their shared parent or pass the width into the Toolbar directly. That should keep the navigation controls aligned near the sidebar’s right edge at every sidebar width while preserving the traffic-light safe area when the sidebar is closed.

The underlying feature otherwise checks out in my workflow. Happy to test an adjustment or contribute the small layout fix if helpful.

bholmesdev and others added 2 commits July 11, 2026 09:11
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@bholmesdev

Copy link
Copy Markdown
Owner

Thanks @jambronner! Fixed that layout issue and a few other edge cases. Glad the functionality works on your end.

@bholmesdev

Copy link
Copy Markdown
Owner
navigation-demo.mp4

Demo of functionality. Note that each workspace has its own history stack and files outside of that workspace still participate in the history stack.

@bholmesdev bholmesdev marked this pull request as ready for review July 11, 2026 13:21
@bholmesdev bholmesdev merged commit 7ab61b3 into main Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add backward / forward navigation and keyboard shortcuts

3 participants