Add ZLab I1 segmented checkpointing support - #2961
Merged
bghira merged 1 commit intoAug 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds segmented checkpointing support for the ZLab I1 transformer family, integrating the shared segmented-checkpointing runtime hooks into the model implementation and ensuring the family is permitted by safety checks and covered by targeted tests.
Changes:
- Implement segmented checkpointing execution in
ZlabI1Transformer2DModel.forward()usingcheckpoint_sequential_stateandshould_checkpoint_block. - Add ZLab I1 to safety-check allow-lists for interval and segment-stride checkpointing controls.
- Add/extend unit tests validating both the presence of checkpointing controls and the ZLab I1 transformer’s use of the sequential-state helper.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
simpletuner/helpers/models/zlab_i1/transformer.py |
Adds interval/stride fields + setters and integrates segmented checkpointing into the ZLab I1 forward pass. |
simpletuner/helpers/training/default_settings/safety_check.py |
Allow-lists zlab_i1 for checkpoint interval and segment stride options. |
tests/test_zlab_i1_model.py |
Adds a unit test asserting ZLab I1 segmented checkpointing routes through checkpoint_sequential_state. |
tests/test_segmented_checkpointing_model_support.py |
Adds model-family support test coverage for ZLab I1 checkpointing controls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 10:23
4047612 to
6c2bf83
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 10:45
6c2bf83 to
a2cda25
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 15:30
a2cda25 to
d51fcec
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 15:32
d51fcec to
a32d87f
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 15:33
a32d87f to
ad41cde
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-zlab-i1
branch
from
August 3, 2026 15:35
ad41cde to
aa39320
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the ZLab I1 segmented checkpointing support model integration out of #2925.
Stack
Base branch:
agent/segmented-checkpointing-z-imageValidation
.venv/bin/python -m unittest tests.test_segmented_checkpointing_model_support -v.venv/bin/python -m unittest tests.test_zlab_i1_model -v